feat: adopt poetry #1172
feat: adopt poetry #1172
Conversation
mattwang44
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 71.00% 70.98% -0.02%
==========================================
Files 85 84 -1
Lines 3445 3440 -5
==========================================
- Hits 2446 2442 -4
+ Misses 999 998 -1 ☔ View full report in Codecov by Sentry. |
mattwang44
force-pushed
the
upgrade-python-310
branch
from
4f775a8
to
e4af425
Compare
There was a problem hiding this comment.
just being picky: for some users using Mac with chip M1 as me, L12 will have to revise to
"export DOCKER_DEFAULT_PLATFORM=linux/arm64/v8"
manually. Maybe note this at quotes inside or readme?
There was a problem hiding this comment.
i use M1 and I've never needed to change these before. I believe it's another issue that we need to dig in. Let's open another ticket/issue for this, shall we?
There was a problem hiding this comment.
P.S. I followed this instruction to install x86 versions of homebrew and have my terminal opened with rosetta by default, and I also followed this instruction to properly setup terminal profiles in VSCode. I believe these settings have saved me from a bunch of system issues on M1.
There was a problem hiding this comment.
good idea. I will move the further discussion at #1175
Types of changes
resolve #1137
Description
Adopt poetry as the package management tool and the virtual env management tool