Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style.py: Get CSS class .inv_foreground in sync with .body_foreground #160

Merged
merged 1 commit into from
May 9, 2022

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Feb 2, 2022

.inv* CSS classes were meant to be the exact opposite of their counterpart. So with Rule(".body_foreground", color=("#000000", "#AAAAAA")[dark_bg]) then class .inv_foreground should have been #AAAAAA rather than #FFFFFF from the beginning.

@hartwork hartwork requested a review from ssbarnea as a code owner February 2, 2022 22:49
@hartwork hartwork added the bug This issue/PR relates to a bug. label Feb 2, 2022
@hartwork hartwork changed the title style.py: Get .inv_foreground in sync with .body_foreground style.py: Get CSS class .inv_foreground in sync with .body_foreground Feb 2, 2022
.inv* CSS classes were meant to be the exact opposite of their
counterpart.  So with
Rule(".body_foreground", color=("#000000", "#AAAAAA")[dark_bg])
then class .inv_foreground should have been #AAAAAA rather
than #FFFFFF from the beginning.
@hartwork hartwork added this to the 1.7.1 milestone May 8, 2022
@ssbarnea ssbarnea merged commit da133eb into pycontribs:main May 9, 2022
@hartwork hartwork deleted the fix-inv-foreground branch May 10, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants