-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add truecolor support #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks ok but ping me back once you pass the linters.
Of course, just didn't have time for it yet. |
Any change to add some tests to cover for the reducing of code coverage? Click on the codecov report to see what you added but without test coverage. Sorry for nagging you about that but reducing coverage is a recipe for future regressions. |
No problem, I'll add more negative tests. |
codecov/project — 94.16% (+1.31%) compared to da3a275 |
I made a pre-release https://github.com/pycontribs/ansi2html/releases/tag/1.7.0a0 -- feel free to make use of it and ping me back in one week if it proves to work, so I can make it a full release. |
@ssbarnea |
Resolves #101