Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truecolor support #155

Merged
merged 9 commits into from
Jan 28, 2022
Merged

Add truecolor support #155

merged 9 commits into from
Jan 28, 2022

Conversation

miltolstoy
Copy link
Contributor

Resolves #101

@miltolstoy miltolstoy requested a review from ssbarnea as a code owner January 25, 2022 06:19
@ssbarnea ssbarnea added the enhancement This issue/PR relates to a feature request. label Jan 25, 2022
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks ok but ping me back once you pass the linters.

@miltolstoy
Copy link
Contributor Author

In general it looks ok but ping me back once you pass the linters.

Of course, just didn't have time for it yet.

@miltolstoy miltolstoy requested a review from ssbarnea January 26, 2022 05:31
@ssbarnea ssbarnea changed the title truecolor support Add truecolor support Jan 27, 2022
@ssbarnea
Copy link
Member

Any change to add some tests to cover for the reducing of code coverage? Click on the codecov report to see what you added but without test coverage.

Sorry for nagging you about that but reducing coverage is a recipe for future regressions.

@ssbarnea ssbarnea requested a review from ziegenberg January 27, 2022 10:29
@miltolstoy
Copy link
Contributor Author

Any change to add some tests to cover for the reducing of code coverage? Click on the codecov report to see what you added but without test coverage.

No problem, I'll add more negative tests.

@miltolstoy
Copy link
Contributor Author

codecov/project — 94.16% (+1.31%) compared to da3a275

@ssbarnea ssbarnea merged commit 01d9635 into pycontribs:main Jan 28, 2022
@ssbarnea
Copy link
Member

I made a pre-release https://github.com/pycontribs/ansi2html/releases/tag/1.7.0a0 -- feel free to make use of it and ping me back in one week if it proves to work, so I can make it a full release.

@miltolstoy miltolstoy deleted the truecolor branch January 31, 2022 04:44
@miltolstoy
Copy link
Contributor Author

I made a pre-release https://github.com/pycontribs/ansi2html/releases/tag/1.7.0a0 -- feel free to make use of it and ping me back in one week if it proves to work, so I can make it a full release.

@ssbarnea
Works fine for my case. You can make a full release.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not support 24-bit "truecolor" escape sequences.
2 participants