Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linting dependencies #147

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Update linting dependencies #147

merged 1 commit into from
Oct 28, 2021

Conversation

ziegenberg
Copy link
Collaborator

@ziegenberg ziegenberg commented Oct 26, 2021 •
edited
Loading

updating build dependencies and linting

  • bump flake8 to 4.0.1
  • bump pydocstyle to 6.1.1
  • bump flake8-docstrings to 1.6.0
  • bump flake8-absolute-import to 1.0
  • bump flake8-black to 0.2.3
  • bump black to 21.9b0 (also repositoy for black moved to https://github.com/psf/black.git)

@ziegenberg ziegenberg requested a review from ssbarnea as a code owner October 26, 2021 12:42
@ziegenberg ziegenberg added the bug This issue/PR relates to a bug. label Oct 26, 2021
@ziegenberg ziegenberg mentioned this pull request Oct 26, 2021
Merged
@ziegenberg
Copy link
Collaborator Author

This is also ready for review.

ssbarnea
ssbarnea reviewed Oct 27, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@ssbarnea ssbarnea changed the title updating build dependencies Update build dependencies Oct 28, 2021
ssbarnea
ssbarnea requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid touching pyproject.toml in this change. Once done we can merge the rest.

@ziegenberg
Copy link
Collaborator Author

What is your policy on updating build dependencies?

setuptools_scm_git_archive 1.0 is from 2015 and version 1.1 was released in 2019.
setuptools v41 was released April 2019 and the current version is v58. In v45 they dropped Python 2 support and v51 raised the bar to Python 3.6.

@ziegenberg
updating build dependencies
4ccfbac 
 - bump pip to 21.3.1
 - bump toml to 0.10.2
 - bump twine to 3.4.2
 - bump flake8 to 4.0.1
 - bump pydocstyle to 6.1.1
 - bump flake8-docstrings to 1.6.0
 - bump flake8-absolute-import to 1.0
 - bump flake8-black to 0.2.3
 - bump black to 21.9b0 (also repositoy for black moved to https://github.com/psf/black.git)

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg changed the title Update build dependencies Update linting dependencies Oct 28, 2021
@ziegenberg
Copy link
Collaborator Author

Only updates of linting dependencies are left. It's ready for review.

@ssbarnea ssbarnea merged commit 5f9d317 into pycontribs:main Oct 28, 2021
@ssbarnea
Copy link
Member

@ziegenberg Policy on build requirements is to only bump them when needed (aka when we find a bug with an older one).

@ziegenberg ziegenberg deleted the update-linting branch October 30, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziegenberg @ssbarnea