Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unittest.mock instead of mock #169

Closed
pgajdos opened this issue Apr 27, 2022 · 2 comments · Fixed by #171
Closed

use unittest.mock instead of mock #169

pgajdos opened this issue Apr 27, 2022 · 2 comments · Fixed by #171

Comments

@pgajdos
Copy link

pgajdos commented Apr 27, 2022 •
edited
Loading

Could you please consider to utilize built-in unittest.mock?

sed -i 's:from mock:from unittest.mock:' tests/test_ansi2html.py

works for me.
@hartwork hartwork mentioned this issue May 8, 2022
Merged
@hartwork
Copy link
Collaborator

hartwork commented May 8, 2022

@pgajdos good point, addressed by new PR #171.

@pgajdos
Copy link
Author

pgajdos commented May 9, 2022

Thanks!

ssbarnea pushed a commit that referenced this issue May 9, 2022
@hartwork
Migrate from mock to unittest.mock of Python >=3.3 (fixes #169) (#171)
3148ee3
nehaljwani added a commit to regro-cf-autotick-bot/ansi2html-feedstock that referenced this issue Sep 26, 2023
@nehaljwani
Remove dependency on mock
28afb3d 
xref: pycontribs/ansi2html#169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from mock to unittest.mock of Python >=3.3 (fixes #169) hartwork/ansi2html
2 participants
@hartwork @pgajdos