(EC)DSA signature fix #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
previously approved these changes
Jul 20, 2017
This fixes a potential heap buffer overflow that may happen when a signature is longer than the private key, as with X9.62 ECDSA (pyca#609).
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 96.94% 96.95% +<.01%
==========================================
Files 18 18
Lines 5737 5746 +9
Branches 401 401
==========================================
+ Hits 5562 5571 +9
Misses 117 117
Partials 58 58
Continue to review full report at Codecov.
|
hynek
approved these changes
Jul 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #668