OpenSSL loading backend #959

public · 2014-04-23T21:03:37Z

No description provided.

jenkins-cryptography · 2014-04-23T21:16:55Z

Test FAILed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1610/

public · 2014-04-23T21:48:46Z

Unscrewed my awful merge.

jenkins-cryptography · 2014-04-23T22:02:03Z

Test FAILed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1611/

public · 2014-04-23T22:10:19Z

Or not...

jenkins-cryptography · 2014-04-23T22:26:36Z

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1612/

jenkins-cryptography · 2014-04-23T22:36:21Z

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1613/

jenkins-cryptography · 2014-04-23T23:15:40Z

Test FAILed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1614/

public · 2014-04-24T08:35:57Z

More network failures :(

reaperhulk · 2014-04-26T01:08:32Z

this can be rebased now

public · 2014-04-26T12:19:49Z

Rebased.

reaperhulk · 2014-04-26T14:09:05Z

docs/hazmat/primitives/asymmetric/serialization.rst

+
+    .. versionadded:: 0.4
+
+    Deserialize a private key from PEM encoded data to one the supported


to one of the supported

public · 2014-04-27T11:33:26Z

Updated.

jenkins-cryptography · 2014-04-27T13:57:02Z

Test FAILed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1664/

reaperhulk · 2014-04-27T14:08:03Z

docs/hazmat/primitives/asymmetric/serialization.rst

+        password was supplied.
+
+    :raises UnsupportedAlgorithm: If the serialized key is of a type that
+        is not supported by the backend or if the


This can be rewrapped a bit.

reaperhulk · 2014-04-27T14:08:27Z

Other than my nit I am 👍 on this. Would like another set of eyes to ensure we're all happy with the approach though.

jenkins-cryptography · 2014-04-27T20:00:47Z

Test FAILed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1666/

public · 2014-04-28T06:55:12Z

I updated this last night.

lvh · 2014-04-28T19:54:48Z

I think the code here looks good, and so do the docs. Not a super huge fan of the "traditional" OpenSSL term, but I can't really come up with anything better either.

exarkun · 2014-04-28T19:55:40Z

docs/hazmat/primitives/asymmetric/serialization.rst

+Traditional OpenSSL Format
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The "traditional" PKCS #1 based serialization format used by OpenSSL.


I think it would help to be more explicit in this documentation that the name "traditional" as used here is a new invention to unambiguously refer to this serialization format. As is, it reads as if there is an alternative to the traditional format that I might be interested in.

This isn't a new name for anything, the OpenSSL docs explicitly refer to
this as the "traditional" format quotes and all. I might be able to improve
the wording a bit though.

On 28 April 2014 20:55:50 Jean-Paul Calderone notifications@github.com wrote:

+.. hazmat::
+
+Key Serialization
+=================
+
+.. currentmodule:: cryptography.hazmat.primitives.serialization
+
+There are several common schemes for serializing asymmetric private and
public
+keys to bytes. They generally support encryption of private keys and
additional
+key metadata.
+
+
+Traditional OpenSSL Format
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The "traditional" PKCS #1 based serialization format used by OpenSSL.

I think it would help to be more explicit in this documentation that the
name "traditional" as used here is a new invention to unambiguously refer
to this serialization format. As is, it reads as if there is an
alternative to the traditional format that I might be interested in.

Reply to this email directly or view it on GitHub:
https://github.com/pyca/cryptography/pull/959/files#r12064446

public · 2014-05-03T18:44:44Z

Rebased for 0.4

jenkins-cryptography · 2014-05-03T19:04:48Z

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1738/

coveralls · 2014-05-03T19:12:41Z

Coverage remained the same when pulling 0d070cf on public:openssl-loading-backend into 1c851f6 on pyca:master.

jenkins-cryptography · 2014-05-03T20:37:25Z

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1742/

public · 2014-05-03T20:51:27Z

Now with DSA support.

jenkins-cryptography · 2014-05-03T21:07:09Z

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1743/

coveralls · 2014-05-03T21:07:23Z

Coverage remained the same when pulling 595393d on public:openssl-loading-backend into 1c851f6 on pyca:master.

reaperhulk · 2014-05-06T13:43:09Z

This LGTM other than our continued naming questions, but it's becoming hard to review since I've seen it so many times. Before we spend time on naming I'd like to see if others think this is ready to merge. cc @alex @dreid @Ayrx

Ayrx · 2014-05-06T14:07:15Z

Code LGTM.

lvh · 2014-05-16T15:26:42Z

cryptography/hazmat/backends/openssl/backend.py

+
+        return _MemoryBIO(self._ffi.gc(bio, self._lib.BIO_free), data_char_p)
+
+    def _evp_pkey_to_private_key(self, evp_pkey):


I would be happier if this had a docstring, if only to document the intent and return type.

lvh · 2014-05-16T15:32:30Z

Other than the docstring nitpicks I think this looks great and I'll be happy to merge it :) Thanks for working on this, @public !

public · 2014-05-16T20:07:03Z

Updated @lvh

jenkins-cryptography · 2014-05-16T20:22:11Z

Test FAILed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1799/

reaperhulk · 2014-05-21T19:09:16Z

Okay, if there are no objections I am going to merge this tomorrow. :) If you want to see changes or disagree with the naming you've got one day to speak up!

OpenSSL loading backend

public changed the title ~~Openssl loading backend~~ OpenSSL loading backend Apr 23, 2014

alex added backend labels Apr 25, 2014

reaperhulk reviewed Apr 26, 2014
View reviewed changes

reaperhulk added this to the Fourth Release milestone Apr 26, 2014

reaperhulk reviewed Apr 27, 2014
View reviewed changes

exarkun reviewed Apr 28, 2014
View reviewed changes

reaperhulk modified the milestones: Fifth Release, Fourth Release May 1, 2014

OpenSSL key loading implementation

0d070cf

Bump to 0.5

d798d7a

DSA support

595393d

public modified the milestone: Fifth Release May 4, 2014

lvh reviewed May 16, 2014
View reviewed changes

Updated docstrings

307b6cb

reaperhulk added a commit that referenced this pull request May 22, 2014

Merge pull request #959 from public/openssl-loading-backend

ebf1235

OpenSSL loading backend

reaperhulk merged commit ebf1235 into pyca:master May 22, 2014

github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenSSL loading backend #959

OpenSSL loading backend #959

public commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

public commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

public commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

public commented Apr 24, 2014

reaperhulk commented Apr 26, 2014

public commented Apr 26, 2014

reaperhulk Apr 26, 2014

public commented Apr 27, 2014

jenkins-cryptography commented Apr 27, 2014

reaperhulk Apr 27, 2014

reaperhulk commented Apr 27, 2014

jenkins-cryptography commented Apr 27, 2014

public commented Apr 28, 2014

lvh commented Apr 28, 2014

exarkun Apr 28, 2014

public Apr 28, 2014

public commented May 3, 2014

jenkins-cryptography commented May 3, 2014

coveralls commented May 3, 2014

jenkins-cryptography commented May 3, 2014

public commented May 3, 2014

jenkins-cryptography commented May 3, 2014

coveralls commented May 3, 2014

reaperhulk commented May 6, 2014

Ayrx commented May 6, 2014

lvh May 16, 2014

lvh commented May 16, 2014

public commented May 16, 2014

jenkins-cryptography commented May 16, 2014

reaperhulk commented May 21, 2014


		.. versionadded:: 0.4

		Deserialize a private key from PEM encoded data to one the supported


		return _MemoryBIO(self._ffi.gc(bio, self._lib.BIO_free), data_char_p)

		def _evp_pkey_to_private_key(self, evp_pkey):

OpenSSL loading backend #959

OpenSSL loading backend #959

Conversation

public commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

public commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

public commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

jenkins-cryptography commented Apr 23, 2014

public commented Apr 24, 2014

reaperhulk commented Apr 26, 2014

public commented Apr 26, 2014

reaperhulk Apr 26, 2014

Choose a reason for hiding this comment

public commented Apr 27, 2014

jenkins-cryptography commented Apr 27, 2014

reaperhulk Apr 27, 2014

Choose a reason for hiding this comment

reaperhulk commented Apr 27, 2014

jenkins-cryptography commented Apr 27, 2014

public commented Apr 28, 2014

lvh commented Apr 28, 2014

exarkun Apr 28, 2014

Choose a reason for hiding this comment

public Apr 28, 2014

Choose a reason for hiding this comment

public commented May 3, 2014

jenkins-cryptography commented May 3, 2014

coveralls commented May 3, 2014

jenkins-cryptography commented May 3, 2014

public commented May 3, 2014

jenkins-cryptography commented May 3, 2014

coveralls commented May 3, 2014

reaperhulk commented May 6, 2014

Ayrx commented May 6, 2014

lvh May 16, 2014

Choose a reason for hiding this comment

lvh commented May 16, 2014

public commented May 16, 2014

jenkins-cryptography commented May 16, 2014

reaperhulk commented May 21, 2014