Expose SSL_CTX_(get|set)_keylog_callback #5179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to have broken tests on versions < 1.1.1 |
|
I fixed the 1.1.1 builds and broke Travis in return. All jobs pass now, it just doesn't report back properly: https://travis-ci.org/github/pyca/cryptography/builds/671573605. Re-triggering doesn't help. Let me know if you need a new PR because of that. :) |
|
Ugh, travis isn't reporting results. Doing the weird hack. |
|
@mhils can you merge/rebase master or something here? Travis is rudely refusing to submit status. |
|
Already tried that. New PR it is. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the new cryptography release! 😃🍰
We're currently upgrading @mitmproxy and it looks like our SSLKEYLOGFILE implementation breaks somewhere between OpenSSL 1.1.1d and 1.1.1f. This is something we can implement ugly workarounds for at the moment, but the long-term fix is to just use SSL_CTX_set_keylog_callback (thanks for building that, @Lukasa!). There will be a follow-up PR for pyOpenSSL once this one has landed.