Comply with PEP 508 by using platform_python_implementation #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will close this in a week, if no one takes care of this. |
|
No need to close this. Both of pyca/cryptography's current maintainers are currently somewhat burned out on it, so we're signifantly slower to respond (and OpenSSL broke our tests so we can't straightforwardly merge things) |
|
@alex Okay. Is there anything a regular user could do to help? |
|
@seppeljordan Can you rebase/merge master please? Also does this change the supported versions of pip/setuptools? |
reaperhulk
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Okay so our setuptools requirement is >=18.5 in setup.py but 40.5 in pyproject.toml. Looks like https://gsnedders.github.io/python-marker-test/results.html indicates we’re fine with this change for things that actually read pyproject.toml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.