Add a test utility functions to read & process NIST vector files #29
Conversation
|
|
||
|
|
||
| def load_nist_vectors_from_file(base, filename, op, fields): | ||
| with open(os.path.join(base, filename), "r") as vector_file: |
There was a problem hiding this comment.
Is there a reason for base to be an argument ant not automatic?
There was a problem hiding this comment.
It makes calling simpler when using it in the test libraries, because you can do something like functools.partial(load_nist_vectors_from_file, NIST_VECTORS_DIR) and then from there on out jsut pass in the filenames, op, and fields instead of needing to repeat the vectors directory over and over.
There was a problem hiding this comment.
Alternative is just assuming the base directory in this function. I could do that, it felt cleaner this way but I'm happy either way.
There was a problem hiding this comment.
I guess I don't have a strong opinion.
There was a problem hiding this comment.
If we assume the base directory it becomes simpler to call it (no need to use functools) so I guess it makes sense to do that.
Add a test utility functions to read & process NIST vector files
No description provided.