Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow SPKI RSA keys to be parsed even if they have an incorrect delimiter #10248

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

reaperhulk
Copy link
Member

This allows RSA SPKI keys (typically delimited with PUBLIC KEY) to be parsed even if they are using the RSA PUBLIC KEY delimiter.

refs #10121

…iter

This allows RSA SPKI keys (typically delimited with PUBLIC KEY) to be parsed
even if they are using the RSA PUBLIC KEY delimiter.
src/rust/src/backend/keys.rs Outdated Show resolved Hide resolved
src/rust/src/backend/keys.rs Outdated Show resolved Hide resolved
@alex alex enabled auto-merge (squash) January 25, 2024 01:54
@alex alex merged commit 075925f into pyca:main Jan 25, 2024
58 checks passed
@reaperhulk reaperhulk deleted the delimiter branch January 25, 2024 01:55
reaperhulk added a commit to reaperhulk/cryptography that referenced this pull request Jan 25, 2024
…iter (pyca#10248)

* allow SPKI RSA keys to be parsed even if they have an incorrect delimiter

This allows RSA SPKI keys (typically delimited with PUBLIC KEY) to be parsed
even if they are using the RSA PUBLIC KEY delimiter.

* formatting

* use original error if nothing parses, don't let it parse non-RSA
alex pushed a commit that referenced this pull request Jan 25, 2024
…iter (#10248) (#10251)

* allow SPKI RSA keys to be parsed even if they have an incorrect delimiter

This allows RSA SPKI keys (typically delimited with PUBLIC KEY) to be parsed
even if they are using the RSA PUBLIC KEY delimiter.

* formatting

* use original error if nothing parses, don't let it parse non-RSA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants