-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Pybricks Beta does not overwrite existing file on import if requested to overwrite #975
Comments
Huh?? If I set and unset the "remember" flag on the dialog and then press the red replace button, then the replace works. If I do not touch the "remember" flag on the dialog, the replace is not done, each time. |
If the program is open as programming tab then the replace also does not work |
When we import/replace a file that is open in an editor, instead of modifying the file in storage, we need to modify the file in the editor. This allows the modification to be pushed on the undo stack so that the user can undo the change in case it wrote over any of their recent changes. Issue: pybricks/support#975
When we import/replace a file that is open in an editor, instead of modifying the file in storage, we need to modify the file in the editor. This allows the modification to be pushed on the undo stack so that the user can undo the change in case it wrote over any of their recent changes. Issue: pybricks/support#975
I think I got this fixed in Pybricks Code v2.2.0-beta.5. At least the case replacing a file that is open in the editor. Let us know if you still have other issues with this. |
Works for me. I am just not sure that the remember flag is indeed remembered. And not related but good to see copied from the status bar:
|
Describe the bug
Import of file already existing in beta.pybricks.com neatly shows dialog.
But a press on the red replace button does not cause the imported file to be really loaded.
To reproduce
In beta.pybricks.com add a new program:
Save the program in
Z:\home\bert\py\pybricks\issue
as
try_overwrite.py
Update the program in beta.pybricks.com like this:
Now import the original saved program.
dialog shows:
Press the red replace button.
No error shown.
Close
try_overwrite.py
in the active tab andre-open
try_overwrite.py
and see still the updated source, not the original saved one (as was saved).Screenshot:
Expected behavior
See newly imported version of source.
Environment
Pybricks v3.3.0b2 (Pybricks Beta v2.2.0-beta.1)
Windows 11 Ver 22H2
Microsoft Edge Version 110.0.1587.63 (Official build) (64-bit)
EDIT: typo (still wrong in description "exsisting")
The text was updated successfully, but these errors were encountered: