Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow sub-millimeter wheel diameter and axle track #830

Closed
laurensvalk opened this issue Dec 6, 2022 · 1 comment
Closed

[Feature] Allow sub-millimeter wheel diameter and axle track #830

laurensvalk opened this issue Dec 6, 2022 · 1 comment
Assignees
@laurensvalk
Labels
enhancement New feature or request software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: motors Issues involving motors

Comments

@laurensvalk
Copy link
Member

laurensvalk commented Dec 6, 2022 •
edited
Loading

Allow sub-millimeter (floating point) dimensions. The low-level code implicitly supports this already anyway.

Originally posted by @laurensvalk in #698 (comment)
@laurensvalk laurensvalk changed the title [Feature] A [Feature] Allow sub-millimeter wheel diameter and axle track Dec 6, 2022
@laurensvalk laurensvalk added software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: motors Issues involving motors enhancement New feature or request labels Dec 6, 2022
@laurensvalk laurensvalk mentioned this issue Mar 17, 2023
Closed
@laurensvalk
Copy link
Member Author

This is used by @TheWendyPower's team in #989 (comment).

left_motor = Motor(Port.B,Direction.COUNTERCLOCKWISE)
right_motor = Motor(Port.C,Direction.CLOCKWISE)
motor_pair = DriveBase(
    left_motor=left_motor,
    right_motor=right_motor,
    wheel_diameter=87.56,
    axle_track=111.46)

Right now, anything after the decimal point is discarded, but since we've upgraded the internal resolution already, we should upgrade this user call too.

@laurensvalk laurensvalk self-assigned this Mar 18, 2023
laurensvalk added a commit to pybricks/pybricks-micropython that referenced this issue Mar 18, 2023
@laurensvalk
pbio/drivebase: Use micrometers for dimensions.
02e2cc8 
This allows the user to specify the drivebase dimensions with
a decimal mm value.

Fixes pybricks/support#830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurensvalk laurensvalk

Labels
enhancement New feature or request software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) topic: motors Issues involving motors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurensvalk