Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] DFU can be started multiple times #1146

Closed
laurensvalk opened this issue Jul 8, 2023 · 0 comments
Closed

[Bug] DFU can be started multiple times #1146

laurensvalk opened this issue Jul 8, 2023 · 0 comments
Assignees
@dlech
Labels
bug Something isn't working hub: primehub/inventorhub Issues related to the LEGO SPIKE Prime hub and LEGO MINDSTORMS Robot Invetor hub platform: essentialhub Issues related to the LEGO SPIKE Essential hub software: pybricks-code Issues with https://code.pybricks.com application topic: USB Issues related to USB

Comments

@laurensvalk
Copy link
Member

Describe the bug
When DFU install is in progress, a second install can be started on the same hub.

This ultimately results in a USB Error, but the hub gets quite confused. After unplugging the battery and restoring the firmware everything worked again.

To reproduce
It's easier to do in the restore step with fewer clicks.

Expected behavior
I know we can't control the Web USB visibility. Maybe have the install/restore button not enabled while DFU is used?
@laurensvalk laurensvalk added bug Something isn't working hub: primehub/inventorhub Issues related to the LEGO SPIKE Prime hub and LEGO MINDSTORMS Robot Invetor hub software: pybricks-code Issues with https://code.pybricks.com application topic: USB Issues related to USB platform: essentialhub Issues related to the LEGO SPIKE Essential hub labels Jul 8, 2023
dlech added a commit to pybricks/pybricks-code that referenced this issue Jul 12, 2023
@dlech
firmware: disable buttons when DFU in progress
6ca66ec 
This avoids trying to perform two DFU operations on the same device
at one time. Flashing is so fast, this seems the better option than
trying to support flashing more than one device at a time.

Fixes: pybricks/support#1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlech dlech

Labels
bug Something isn't working hub: primehub/inventorhub Issues related to the LEGO SPIKE Prime hub and LEGO MINDSTORMS Robot Invetor hub platform: essentialhub Issues related to the LEGO SPIKE Essential hub software: pybricks-code Issues with https://code.pybricks.com application topic: USB Issues related to USB
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlech @laurensvalk