pbio/sys/hmi: Reduce time needed to power off hub. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was requested among others by @biasedlogic. |
|
We will merge this since there haven't been any objections for a month. If anyone needs a longer shutdown-time out, please feel free to open a new issue. Then we make make the duration a user-configurable setting. Perhaps as a second argument to the existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the power off time from 3 to 2 seconds. This has been requested occasionally. I think this is OK.
If it makes certain use cases harder, like long press menus, we could now quite easily add a user setting to make this timeout configurable due to pybricks/support#1622 now being implemented.