Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters class #322

Merged
merged 52 commits into from
Jun 5, 2024
Merged

Add parameters class #322

merged 52 commits into from
Jun 5, 2024

Commits on May 10, 2024

  1. Add Parameters class

    @NicolaCourtier
    NicolaCourtier committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7a7d735 View commit details
    Browse the repository at this point in the history

  2. Update error type

    @NicolaCourtier
    NicolaCourtier committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f9993cf View commit details
    Browse the repository at this point in the history

  3. Update parameters in tests

    @NicolaCourtier
    NicolaCourtier committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b894247 View commit details
    Browse the repository at this point in the history

  4. Update parameters in examples

    @NicolaCourtier
    NicolaCourtier committed May 10, 2024
    Configuration menu
    Copy the full SHA
    518b1eb View commit details
    Browse the repository at this point in the history

  5. Update parameters in notebooks

    @NicolaCourtier
    NicolaCourtier committed May 10, 2024
    Configuration menu
    Copy the full SHA
    916fa4f View commit details
    Browse the repository at this point in the history

  6. Update parameter name

    @NicolaCourtier
    NicolaCourtier committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7a11dac View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Add parameters len and tests

    @NicolaCourtier
    NicolaCourtier committed May 13, 2024
    Configuration menu
    Copy the full SHA
    75780d9 View commit details
    Browse the repository at this point in the history

  2. Delay unpacking of parameter properties

    @NicolaCourtier
    NicolaCourtier committed May 13, 2024
    Configuration menu
    Copy the full SHA
    08db908 View commit details
    Browse the repository at this point in the history

  3. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9265528 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into 258-parameters-class

    @NicolaCourtier
    NicolaCourtier committed May 13, 2024
    Configuration menu
    Copy the full SHA
    76ae239 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'develop' into 258-parameters-class

    @NicolaCourtier
    NicolaCourtier committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a0c0845 View commit details
    Browse the repository at this point in the history

  2. Replace sample_initial_conditions

    @NicolaCourtier
    NicolaCourtier committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f46e83b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Update test_thevenin_parameterisation.py

    @NicolaCourtier
    NicolaCourtier committed May 20, 2024
    Configuration menu
    Copy the full SHA
    5fd728c View commit details
    Browse the repository at this point in the history

  2. Test without flaky

    @NicolaCourtier
    NicolaCourtier committed May 20, 2024
    Configuration menu
    Copy the full SHA
    1515703 View commit details
    Browse the repository at this point in the history

  3. Move x0 def to parameters

    @NicolaCourtier
    NicolaCourtier committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e343dcf View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Add parameters.update

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8ffc859 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ece7df0 View commit details
    Browse the repository at this point in the history

  3. Define n_parameters for model

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    288d9b3 View commit details
    Browse the repository at this point in the history

  4. Make fit_keys a property

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    acc4b7b View commit details
    Browse the repository at this point in the history

  5. Add parameters as_dict

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cb09d14 View commit details
    Browse the repository at this point in the history

  6. Update exp_UKF.py

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7847195 View commit details
    Browse the repository at this point in the history

  7. Remove fit_keys

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    261e7af View commit details
    Browse the repository at this point in the history

  8. Update comment

    @NicolaCourtier
    NicolaCourtier committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4897a54 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Fixes for notebooks

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    382b65f View commit details
    Browse the repository at this point in the history

  2. Check stricter of relative/absolute tolerance

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    22d3e7f View commit details
    Browse the repository at this point in the history

  3. Change Thevenin parameters

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5dc583e View commit details
    Browse the repository at this point in the history

  4. Update ground truth

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d042e0d View commit details
    Browse the repository at this point in the history

  5. Pass parameters to get_data

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ed9de21 View commit details
    Browse the repository at this point in the history

  6. Update max values to help GradientDescent

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    25807a3 View commit details
    Browse the repository at this point in the history

  7. Reset Thevenin test but with new C1

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ad74dc6 View commit details
    Browse the repository at this point in the history

  8. Equalise integration test settings

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cf7f4e0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into 258-parameters-class

    @NicolaCourtier
    NicolaCourtier committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f2a78e0 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Update default SciPy DE tol

    @NicolaCourtier
    NicolaCourtier committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6555c58 View commit details
    Browse the repository at this point in the history

  2. Relax atol a little

    @NicolaCourtier
    NicolaCourtier committed May 23, 2024
    Configuration menu
    Copy the full SHA
    242b129 View commit details
    Browse the repository at this point in the history

  3. Move sigma0, bounds to BaseOptimiser, update likelihoods

    @NicolaCourtier
    NicolaCourtier committed May 23, 2024
    Configuration menu
    Copy the full SHA
    dae5b82 View commit details
    Browse the repository at this point in the history

  4. Remove unused bounds_for_scipy

    @NicolaCourtier
    NicolaCourtier committed May 23, 2024
    Configuration menu
    Copy the full SHA
    d29f383 View commit details
    Browse the repository at this point in the history

  5. Update from list to args

    @NicolaCourtier
    NicolaCourtier committed May 23, 2024
    Configuration menu
    Copy the full SHA
    063ac74 View commit details
    Browse the repository at this point in the history

  6. Fix test_model_experiment_changes

    @NicolaCourtier
    NicolaCourtier committed May 23, 2024
    Configuration menu
    Copy the full SHA
    48bdd76 View commit details
    Browse the repository at this point in the history

  7. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 23, 2024
    Configuration menu
    Copy the full SHA
    15616a3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Add ValueError for None sigma

    @NicolaCourtier
    NicolaCourtier committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5ddad6c View commit details
    Browse the repository at this point in the history

  2. Rename add_parameter as add

    @NicolaCourtier
    NicolaCourtier committed May 30, 2024
    Configuration menu
    Copy the full SHA
    38525fd View commit details
    Browse the repository at this point in the history

  3. Rename remove_parameter to remove

    @NicolaCourtier
    NicolaCourtier committed May 30, 2024
    Configuration menu
    Copy the full SHA
    248be07 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
    @NicolaCourtier @BradyPlanden
    NicolaCourtier and BradyPlanden committed May 30, 2024
    Configuration menu
    Copy the full SHA
    21630e4 View commit details
    Browse the repository at this point in the history

  5. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed May 30, 2024
    Configuration menu
    Copy the full SHA
    4465869 View commit details
    Browse the repository at this point in the history

  6. Merge branch '258-parameters-class' of https://github.com/pybop-team/… 

    …PyBOP into 258-parameters-class
    @NicolaCourtier
    NicolaCourtier committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5402045 View commit details
    Browse the repository at this point in the history

  7. Update error match

    @NicolaCourtier
    NicolaCourtier committed May 30, 2024
    Configuration menu
    Copy the full SHA
    4e071f5 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Update tolerances and threshold

    @NicolaCourtier
    NicolaCourtier committed May 31, 2024
    Configuration menu
    Copy the full SHA
    455dab5 View commit details
    Browse the repository at this point in the history

  2. Rename update_bounds to set_bounds

    @NicolaCourtier
    NicolaCourtier committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0ba4b52 View commit details
    Browse the repository at this point in the history

  3. Update all_samples to list

    @NicolaCourtier
    NicolaCourtier committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f347ace View commit details
    Browse the repository at this point in the history

  4. Update set_bounds to get_bounds

    @NicolaCourtier
    NicolaCourtier committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5005b9a View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Move check on sigma

    @NicolaCourtier
    NicolaCourtier committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1521512 View commit details
    Browse the repository at this point in the history

  2. Update description

    @NicolaCourtier
    NicolaCourtier committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fbb4b23 View commit details
    Browse the repository at this point in the history