Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AdamW optimiser #316

Merged
merged 16 commits into from
Jun 10, 2024
Merged

Adds AdamW optimiser #316

merged 16 commits into from
Jun 10, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented May 8, 2024

Description

This PR adds an AdamW optimiser to PyBOP. This implementation extends the Pints' Adam class and reimplements it in PyBOP. Adding this upstream to Pints' should also be considered.

This PR should be merged after #255 as it will need to be updated for the new optimiser architecture implemented.

Issue reference

Fixes #295

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@BradyPlanden BradyPlanden linked an issue May 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (9d57d2c) to head (fc6f1c9).
Report is 622 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #316      +/-   ##
===========================================
+ Coverage    97.09%   97.33%   +0.24%     
===========================================
  Files           42       42              
  Lines         2410     2404       -6     
===========================================
  Hits          2340     2340              
+ Misses          70       64       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden changed the title Adds AdamW implementation Adds AdamW optimiser May 9, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
pybop/optimisers/_adamw.py Outdated Show resolved Hide resolved
pybop/optimisers/_adamw.py Outdated Show resolved Hide resolved
pybop/optimisers/_adamw.py Outdated Show resolved Hide resolved
pybop/optimisers/pints_optimisers.py Outdated Show resolved Hide resolved
pybop/optimisers/pints_optimisers.py Outdated Show resolved Hide resolved
pybop/optimisers/_adamw.py Outdated Show resolved Hide resolved
Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks very much @BradyPlanden for the nice addition of the AdamW optimiser. Please update the table in the Readme from Adam to AdamW, otherwise good to go.

@BradyPlanden BradyPlanden merged commit eed0fd0 into develop Jun 10, 2024
29 checks passed
@BradyPlanden BradyPlanden deleted the 295-add-adamw-optimiser branch June 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AdamW Optimiser
2 participants