Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for upcoming PyBaMM v24.5 #313

Merged
merged 16 commits into from
Jul 22, 2024
Merged

Fixes for upcoming PyBaMM v24.5 #313

merged 16 commits into from
Jul 22, 2024

Commits on May 5, 2024

  1. fixes to pybop.experiment, pybop.base_model for pybamm@develop ahead … 

    …of pybamm v24.5
    @BradyPlanden
    BradyPlanden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1f1e91d View commit details
    Browse the repository at this point in the history

  2. increment number of states in spm_UKF example

    @BradyPlanden
    BradyPlanden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1770dc8 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'develop' into 312-bug-synchronise-pybop-with-pybammdevelop

    @BradyPlanden
    BradyPlanden committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a5098f7 View commit details
    Browse the repository at this point in the history

  2. fix: update non-converged DFN test

    @BradyPlanden
    BradyPlanden committed May 22, 2024
    Configuration menu
    Copy the full SHA
    786d9ca View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. update target pybamm source to forked develop w/ diffusivity fix

    @BradyPlanden
    BradyPlanden committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7711a4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 312-bug-synchronise-pybop-with-pybammdevelop

    @BradyPlanden
    BradyPlanden committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    524d2d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. tests: updts to test_non_converged_solution. 

    Changes to pybamm v24.5 have resulted in solver.solve()
to return values for incorrect inputs values when not requesting
sensitivities. This removes the test that assert output == np.inf
in this case.
    @BradyPlanden
    BradyPlanden committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a76959f View commit details
    Browse the repository at this point in the history

  2. test: updt asserts to capture differing outputs

    @BradyPlanden
    BradyPlanden committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c8deb15 View commit details
    Browse the repository at this point in the history

  3. test: revert to allclose as output vector varies for each OS

    @BradyPlanden
    BradyPlanden committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    06dd979 View commit details
    Browse the repository at this point in the history

  4. tests: remove gradient == np.inf assert

    @BradyPlanden
    BradyPlanden committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c261370 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. tests: Add missing asserts

    @BradyPlanden
    BradyPlanden committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    3e40128 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge branch 'develop' into 312-bug-synchronise-pybop-with-pybammdevelop

    @BradyPlanden
    BradyPlanden committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ec94408 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Merge branch 'refs/heads/develop' into 312-bug-synchronise-pybop-with… 

    …-pybammdevelop
    @BradyPlanden
    BradyPlanden committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    2517a6a View commit details
    Browse the repository at this point in the history

  2. build: increment pybamm to 24.5rc2, ci: increment tests alongside.

    @BradyPlanden
    BradyPlanden committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    40133fb View commit details
    Browse the repository at this point in the history

  3. tests: increase coverage, fix flaky observer tests

    @BradyPlanden
    BradyPlanden committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    4c100ff View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'refs/heads/develop' into 312-bug-synchronise-pybop-with… 

    …-pybammdevelop

# Conflicts:
#	tests/unit/test_cost.py
    @BradyPlanden
    BradyPlanden committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d7c53c4 View commit details
    Browse the repository at this point in the history