Fix workflow for changing experiment #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #240 +/- ##
===========================================
+ Coverage 94.29% 94.30% +0.01%
===========================================
Files 33 33
Lines 1753 1757 +4
===========================================
+ Hits 1653 1657 +4
Misses 100 100 ☔ View full report in Codecov by Sentry. |
NicolaCourtier
changed the title
BradyPlanden
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks great — thanks for the fast bugfix @NicolaCourtier! A few small suggestions, happy for you to merge when ready.
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #233. The current function was not being set during the call to
set_paramsunlessunmatched_parameterswere present.