-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for #193 - Add matrix to M-series runner #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks @BradyPlanden – I missed doing that!
Scheduled test running here: https://github.com/pybop-team/PyBOP/actions/runs/7940982485. Looks like I've missed filter for out the duplicates.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #205 +/- ##
========================================
Coverage 94.57% 94.57%
========================================
Files 44 44
Lines 1826 1826
========================================
Hits 1727 1727
Misses 99 99 ☔ View full report in Codecov by Sentry. |
What's the Edit: what I think could be happening is the global Edit 2: yes, looks like we figured it out at the same time! |
This should now be ready for review (no rush, as it's the weekend!). Tests running here: https://github.com/pybop-team/PyBOP/actions/runs/7941250463 with the correct number of entries and the |
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Patches #193 for the M-series runner. See current logs for failing tests, as the noxfile requires a
PYBAMM_VERSION
.