Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for #193 - Add matrix to M-series runner #205

Merged
merged 7 commits into from
Feb 17, 2024

Conversation

BradyPlanden
Copy link
Member

Patches #193 for the M-series runner. See current logs for failing tests, as the noxfile requires a PYBAMM_VERSION.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks @BradyPlanden – I missed doing that!

@BradyPlanden
Copy link
Member Author

BradyPlanden commented Feb 17, 2024

Scheduled test running here: https://github.com/pybop-team/PyBOP/actions/runs/7940982485. Looks like I've missed filter for out the duplicates.

Still running into the pybamm==None issue though. Right, just need to add it to the env.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c72cf71) 94.57% compared to head (c0cfb56) 94.57%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #205   +/-   ##
========================================
  Coverage    94.57%   94.57%           
========================================
  Files           44       44           
  Lines         1826     1826           
========================================
  Hits          1727     1727           
  Misses          99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Feb 17, 2024

Scheduled test running here: https://github.com/pybop-team/PyBOP/actions/runs/7940982485. Looks like I've missed filter for out the duplicates.

Still running into the pybamm==None issue though.

What's the pybamm==None issue?

Edit: what I think could be happening is the global env: does not get percolated into the self-hosted runner, so you might have to set PYBOP_SCHEDULED inside the job for the runner as well.

Edit 2: yes, looks like we figured it out at the same time!

@BradyPlanden
Copy link
Member Author

This should now be ready for review (no rush, as it's the weekend!).

Tests running here: https://github.com/pybop-team/PyBOP/actions/runs/7941250463 with the correct number of entries and the PYBAMM_VERSION env variable caught.

@BradyPlanden BradyPlanden merged commit e9fb74c into develop Feb 17, 2024
19 checks passed
@BradyPlanden BradyPlanden deleted the 193-patch-m-series branch February 17, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants