Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to #177 #198

Merged
merged 26 commits into from
Mar 19, 2024
Merged

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Feb 16, 2024

This adds the following:

  • update subplot trace width via additional DEFAULT_SUBPLOT_TRACE_OPTIONS variable
  • dataset access method,
  • remove square brackets from plots as per SI standard,
  • updates quick plot for varying length signals,
  • adds pybop.is_numeric function for checking input values
  • restores design cost exception for optimisation

Encompasses #224. This PR is also a step towards fixing our current failing scheduled tests.

…ackets from plots as per SI standard, quick plot for varying length signals, add pybop.is_numeric and restore design cost exception for optimisation
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 88.41060% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 94.19%. Comparing base (f9b10e8) to head (41cf0f8).

❗ Current head 41cf0f8 differs from pull request most recent head a479136. Consider uploading reports for the commit a479136 to get more accurate results

Files Patch % Lines
pybop/costs/_likelihoods.py 75.92% 13 Missing ⚠️
pybop/plotting/quick_plot.py 81.81% 4 Missing ⚠️
pybop/costs/fitting_costs.py 93.47% 3 Missing ⚠️
pybop/observers/observer.py 90.00% 3 Missing ⚠️
pybop/models/lithium_ion/echem_base.py 50.00% 2 Missing ⚠️
pybop/plotting/plot_convergence.py 77.77% 2 Missing ⚠️
pybop/plotting/plot_cost2d.py 93.10% 2 Missing ⚠️
pybop/plotting/plot_problem.py 86.66% 2 Missing ⚠️
pybop/costs/design_costs.py 95.23% 1 Missing ⚠️
pybop/plotting/plot_dataset.py 83.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                      Coverage Diff                      @@
##           177-plotting-capabilities     #198      +/-   ##
=============================================================
- Coverage                      94.61%   94.19%   -0.43%     
=============================================================
  Files                             35       36       +1     
  Lines                           1857     1997     +140     
=============================================================
+ Hits                            1757     1881     +124     
- Misses                           100      116      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden linked an issue Feb 16, 2024 that may be closed by this pull request
BradyPlanden and others added 22 commits February 22, 2024 09:12
…y. Update tests, add base model classes to init, cleaner multi-signal interaction
… Discharge capacity as default additional_variable
Datatype restructure for optimisation objects
Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge once the coverage is passing, thanks very much @BradyPlanden!

@BradyPlanden BradyPlanden changed the title [WIP]: Additions to #177 Additions to #177 Mar 19, 2024
@BradyPlanden BradyPlanden merged commit 691b0ae into 177-plotting-capabilities Mar 19, 2024
29 checks passed
@BradyPlanden BradyPlanden deleted the 177b-plotting-capabilities branch March 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update quick_plot for varying trace sizes
2 participants