Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add M1 GitHub runner and update scheduled tests #188

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Feb 9, 2024

This PR:

  • Adds the M1 Github runners to the test_on_push workflow
  • Updates the scheduled_tests workflow to test the self-hosted runner across all supported python versions

Closes #187

@BradyPlanden BradyPlanden linked an issue Feb 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cb7264) 94.67% compared to head (59653d4) 94.56%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
- Coverage    94.67%   94.56%   -0.11%     
===========================================
  Files           44       44              
  Lines         1823     1823              
===========================================
- Hits          1726     1724       -2     
- Misses          97       99       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BradyPlanden – please feel free to merge if you think the failing test is flaky

@BradyPlanden BradyPlanden merged commit a8b54d1 into develop Feb 13, 2024
18 of 19 checks passed
@BradyPlanden BradyPlanden deleted the 187-add-m-series-github-runners-to-tests branch February 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add M-series Github runners to tests
3 participants