Adding notebook examples #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #135 +/- ##
===========================================
+ Coverage 94.07% 94.26% +0.18%
===========================================
Files 36 37 +1
Lines 1351 1377 +26
===========================================
+ Hits 1271 1298 +27
+ Misses 80 79 -1 ☔ View full report in Codecov by Sentry. |
… parameter_set reinit, remove pybamm dependancy from spm_nlopt notebook, increase max_iterations for all optimisers
NicolaCourtier
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Nice work @BradyPlanden - thanks very much, it's great to have some more working examples to demonstrate PyBOP's functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please comment below if you are going to complete on of the notebooks for this PR. Feel free to update this comment with additional notebooks.
Closes #118.