-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address regression introduced in #5381 #5396
Merged
Merged
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8cf1cdb
Incomplete attempt to address regression introduced in #5381
francesco-ballarin 9d107d2
style: pre-commit fixes
pre-commit-ci[bot] b508a07
Revert "style: pre-commit fixes"
francesco-ballarin 95e0325
Revert "Incomplete attempt to address regression introduced in #5381"
francesco-ballarin 8cbca65
Simpler fix for the regression introduced in #5381
francesco-ballarin 4c87a23
style: pre-commit fixes
pre-commit-ci[bot] b375ad7
Added if constexpr workaround
gentlegiantJGC 56758c7
style: pre-commit fixes
pre-commit-ci[bot] e55e864
Replace if constexpr with template struct
gentlegiantJGC badb28d
style: pre-commit fixes
pre-commit-ci[bot] 6494448
Made comment clearer
gentlegiantJGC 84cd376
Added test cases
gentlegiantJGC 1c845cf
style: pre-commit fixes
pre-commit-ci[bot] 5965a65
Fixed is_same_or_base_of reference
gentlegiantJGC add8277
style: pre-commit fixes
pre-commit-ci[bot] c4ce357
Added static assert messages
gentlegiantJGC 8b9e5d1
style: pre-commit fixes
pre-commit-ci[bot] ccb165b
Replaced typedef with using
gentlegiantJGC 8bc767d
style: pre-commit fixes
pre-commit-ci[bot] b7c4fe9
Back out `ForwardClassPtr` (to be discussed separately). Tested local…
rwgk b778cc6
Shuffle new `static_assert()` and leave error messages blank (they ar…
rwgk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC: Neat! (I wish I had known the
decltype(void(sizeof(Derived)))
trick before!)However, I find this comment confusing, or I don't actually understand correctly.
Did you mean this?
Also, where did you find the
decltype(void(sizeof(Derived)))
trick?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was based on code from the top of here (linked in my earlier message)
https://devblogs.microsoft.com/oldnewthing/20190710-00/?p=102678
I don't know how official that is though.
I will make the comment more clear.