fix: quote paths from pybind11-config #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/quotes
branch
from
7691c1c
to
b4f8e4e
Compare
rwgk
approved these changes
Aug 13, 2024
henryiii
added a commit
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
added a commit
that referenced
this pull request
Aug 14, 2024
henryiii
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5300. I've been worried about the warning on https://docs.python.org/3/library/shlex.html#shlex.quote, but I think that doesn't mean it won't work, it just means that it doesn't protect from injection on Windows.
Suggested changelog entry: