fix(cmake): allow forcing old FindPython #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
approved these changes
Feb 27, 2024
tools/pybind11Common.cmake
Outdated
| OR Python_FOUND | ||
| OR Python2_FOUND | ||
| OR Python3_FOUND) | ||
| NOT (DEFINED PYBIND11_FINDPYTHON AND NOT PYBIND11_FINDPYTHON) |
There was a problem hiding this comment.
I find the long combination of conditions difficult to parse/understand.
What do you think about:
- Tiny rewrite of the new additions:
(NOT DEFINED PYBIND11_FINDPYTHON OR PYBIND11_FINDPYTHON)
- Adding a comment, similar to what you wrote in the PR description?
rwgk
approved these changes
Feb 27, 2024
Skylion007
approved these changes
Mar 4, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/oldpython
branch
from
b1f9ae2
to
864aadb
Compare
henryiii
added
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if for some reason the new FindPython triggers, like if Python has been found the new way, you can't get pybind11 to use the old mechanism. If
PYBIND11_FINDPYTHONis both defined and falsy, let's use that to force it off.Suggested changelog entry:
* Setting ``PYBIND11_FINDPYTHON`` to OFF will force the old FindPythonLibs mechanism to be used.