-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format_descriptor<>
& npy_format_descriptor<>
PyObject *
specializations.
#4674
Commits on May 17, 2023
-
Add
npy_format_descriptor<PyObject *>
to enable `py::array_t<PyObje……ct *>` to/from-python conversions.
Ralf W. Grosse-Kunstleve committedMay 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 5168c13 - Browse repository at this point
Copy the full SHA 5168c13View commit details -
Ralf W. Grosse-Kunstleve committed
May 17, 2023 Configuration menu - View commit details
-
Copy full SHA for d53a796 - Browse repository at this point
Copy the full SHA d53a796View commit details -
Use existing constructor instead of adding a static method. Thanks @S…
…kylion007 for pointing out.
Ralf W. Grosse-Kunstleve committedMay 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 5bea2a8 - Browse repository at this point
Copy the full SHA 5bea2a8View commit details -
Add
format_descriptor<PyObject *>
Trivial addition, but still in search for a meaningful test.
Ralf W. Grosse-Kunstleve committedMay 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 50eaa3a - Browse repository at this point
Copy the full SHA 50eaa3aView commit details
Commits on May 18, 2023
-
Add test_format_descriptor_format
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 82ce80f - Browse repository at this point
Copy the full SHA 82ce80fView commit details -
Ensure the Eigen
type_caster
s do not segfault when loading arrays w……ith dtype=object
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 20b9baf - Browse repository at this point
Copy the full SHA 20b9bafView commit details -
Use
static_assert()
!std::is_pointer<>
to replace runtime guards.Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 0640eb3 - Browse repository at this point
Copy the full SHA 0640eb3View commit details -
Add comments to explain how to check for ref-count bugs. (NO code cha…
…nges.)
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for ddb625e - Browse repository at this point
Copy the full SHA ddb625eView commit details -
Make the "Pointer types ... are not supported" message Eigen-specific…
…, as suggested by @lalaland. Move to new pybind11/eigen/common.h header.
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 03dafde - Browse repository at this point
Copy the full SHA 03dafdeView commit details -
Change "format_descriptor_format" implementation as suggested by @lal…
…aland. Additional tests meant to ensure consistency between py::format_descriptor<>, np.array, np.format_parser turn out to be useful only to highlight long-standing inconsistencies.
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 28492ed - Browse repository at this point
Copy the full SHA 28492edView commit details -
Ralf W. Grosse-Kunstleve committed
May 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 1593ebc - Browse repository at this point
Copy the full SHA 1593ebcView commit details -
Account for np.float128, np.complex256 not being available on Windows…
…, in a future-proof way.
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 3f04188 - Browse repository at this point
Copy the full SHA 3f04188View commit details -
Fully address i|q|l ambiguity (hopefully).
Ralf W. Grosse-Kunstleve committedMay 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 38aa697 - Browse repository at this point
Copy the full SHA 38aa697View commit details
Commits on May 19, 2023
-
Remove the new
np.format_parser()
-based test, it's much more distra……cting than useful.
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 7f124bb - Browse repository at this point
Copy the full SHA 7f124bbView commit details -
Use bi.itemsize to disambiguate "l" or "L"
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for d432ce7 - Browse repository at this point
Copy the full SHA d432ce7View commit details -
Use
py::detail::compare_buffer_info<T>::compare()
to validate the `……format_descriptor<T>::format()` strings.
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 18e1bd2 - Browse repository at this point
Copy the full SHA 18e1bd2View commit details -
Add
buffer_info::compare<T>
to make `detail::compare_buffer_info<T>……::compare` more visible & accessible.
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 029b157 - Browse repository at this point
Copy the full SHA 029b157View commit details -
Ralf W. Grosse-Kunstleve committed
May 19, 2023 Configuration menu - View commit details
-
Copy full SHA for d9e3bd3 - Browse repository at this point
Copy the full SHA d9e3bd3View commit details -
pytest-compatible access to np.float128, np.complex256
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for e9a289c - Browse repository at this point
Copy the full SHA e9a289cView commit details -
Revert "pytest-compatible access to np.float128, np.complex256"
This reverts commit e9a289c.
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 8abe0e9 - Browse repository at this point
Copy the full SHA 8abe0e9View commit details -
Use
sizeof(long double) == sizeof(double)
instead ofstd::is_same<>
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for b09e75b - Browse repository at this point
Copy the full SHA b09e75bView commit details -
Report skipped
long double
tests.Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for ba7063e - Browse repository at this point
Copy the full SHA ba7063eView commit details -
Change the name of the new
buffer_info
member function to `item_typ……e_is_equivalent_to`. Add comment defining "equivalent" by example.
Ralf W. Grosse-Kunstleve committedMay 19, 2023 Configuration menu - View commit details
-
Copy full SHA for a4d61b4 - Browse repository at this point
Copy the full SHA a4d61b4View commit details
Commits on May 20, 2023
-
Change
item_type_is_equivalent_to<>()
fromstatic
function to mem……ber function, as suggested by @lalaland
Ralf W. Grosse-Kunstleve committedMay 20, 2023 Configuration menu - View commit details
-
Copy full SHA for ef34d29 - Browse repository at this point
Copy the full SHA ef34d29View commit details