docs: Fix errors in string "Explicit conversions" #4658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PyUnicode_DecodeLatin1
requires you to pass in theerror
parameter. The code as it is in the docs didn't compile.There is a reference leak in the example code.
PyUnicode_DecodeLatin1
returns a new reference. Callingpy::str(PyObject*)
callsPyObject_Str
, which also returns a new reference. That reference is managed by thepy::str
constructor (which correctly steals the reference, using thestolen_t
constructor), but the original reference returned byPyUnicode_DecodeLatin1
is never decref'd: it never makes it into anobject
, and it's never manually decremented.This fixes both of those issues. The code compiles, and I viewed the sphinx docs locally.