Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_modules.py Python 3.12 compatibility #4559

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 9, 2023

Description

Remove test code that does not exercise anything in pybind11, but breaks between Python 3.12alpha3 (still working) and 3.12alpha6 (broken):

str(OrderedDict([(1, "a"), (2, "b")]))

Old:

OrderedDict([(1, 'a'), (2, 'b')])

New:

OrderedDict({1: 'a', 2: 'b'})

See also: python/cpython#101446

Note:

Suggested changelog entry:

…aks between Python 3.12alpha3 (still working) and 3.12alpha6 (broken):

```
str(OrderedDict([(1, "a"), (2, "b")]))
```

Old:
```
OrderedDict([(1, 'a'), (2, 'b')])
```

New:
```
OrderedDict({1: 'a', 2: 'b'})
```

See also: python/cpython#101446
@rwgk rwgk marked this pull request as ready for review March 9, 2023 20:52
@rwgk rwgk requested a review from henryiii March 9, 2023 20:53
@rwgk rwgk merged commit 442261d into pybind:master Mar 9, 2023
@rwgk rwgk deleted the test_modules_py312_compatibility branch March 9, 2023 21:02
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 9, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants