Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to CMake 3.25.2 to resolve macos-latest FindCatch "Could not download" errors #4496

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 7, 2023

Description

Note: a draft rollback for this PR is under #4503 (for reporting the issue to the cmake developers).


I took a close look at a pair of CI logs (Python 3.11 macos-latest):

  • last to succeed (2023-02-02T18:18:14.2041233Z)
  • first to fail (2023-02-02T22:57:24.3630240Z)

This diff looked like a smoking gun:

- -- CMake 3.25.2
+ -- CMake 3.26.0-rc1

Suggested changelog entry:

@rwgk rwgk marked this pull request as ready for review February 7, 2023 10:10
@rwgk rwgk requested a review from henryiii as a code owner February 7, 2023 10:10
@rwgk rwgk requested a review from Skylion007 February 7, 2023 10:10
@rwgk
Copy link
Collaborator Author

rwgk commented Feb 7, 2023

This fixes the CI (macos-latest).

The Pip ubuntu-latest workflow is still failing, but that's for another PR.

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 7, 2023

Idea for after this PR is merged: I'll create another PR (draft) to undo this one, as a reminder to try again in a week or two.

@rwgk rwgk merged commit b8f2855 into pybind:master Feb 8, 2023
@rwgk rwgk deleted the pin_cmake_for_now branch February 8, 2023 04:19
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 8, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 8, 2023
rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Feb 8, 2023
rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Feb 9, 2023
rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Feb 15, 2023
henryiii pushed a commit to rwgk/pybind11 that referenced this pull request Feb 16, 2023
henryiii pushed a commit that referenced this pull request Feb 16, 2023
* Revert "Go back to CMake 3.25.2 (#4496)"

This reverts commit b8f2855.

* Apply patch provided by @bradking (with pre-commit cmake-format auto fixes).

#4503 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants