Overload Signature: Potential Nullptr Deref #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhihaoy
reviewed
Jan 7, 2019
include/pybind11/pybind11.h
Outdated
| @@ -763,7 +763,10 @@ class cpp_function : public function { | |||
| } else if (!result) { | |||
| std::string msg = "Unable to convert function return value to a " | |||
| "Python type! The signature was\n\t"; | |||
| msg += it->signature; | |||
| if (it == nullptr) | |||
| msg += "no signature found (nullptr)"; | |||
There was a problem hiding this comment.
Please change msg to say so; the full phrase
The signature was
no signature found
reads weird.
Fix a potential nullptr in error handling. The `it` variable is already checked in the `try` block for non-nullptr and might therefore be `nullptr` in this branch as well. Found with coverity in a downstream project.
ax3l
force-pushed
the
fix-nullptrErrorHandling
branch
from
a343e20
to
e6d9b4c
Compare
zhihaoy
approved these changes
Jan 7, 2019
|
The catch block can never be reached while |
|
Actually coverity took the following logic: in line 460 with Coverity consequently assumes |
|
During function dispatch, there are 3 basic outcomes:
The case you wanted to patch is related to #3, and it can only happen if #1 and #2 were not taken (and in this case, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a potential nullptr in error handling. The
itvariable is already checked in thetryblock for non-nullptr and might therefore benullptrin this branch as well.Found with coverity in a downstream project.