Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and fail if using mismatched holders #1161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Detect and fail if using mismatched holders #1161

wants to merge 1 commit into from

Commits on Oct 29, 2017

  1. Detect and fail if using mismatched holders 

    This adds a check when registering a class or a function with a holder
return that the same wrapped type hasn't been previously seen using a
different holder type.

This fixes pybind#1138 by detecting the failure; currently attempting to use
two different holder types (e.g. a unique_ptr<T> and shared_ptr<T>) in
difference places can segfault because we don't have any type safety on
the holder instances.
    @jagerman
    jagerman committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    8052783 View commit details
    Browse the repository at this point in the history