Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From Boost.Python to PYBIND11 #5

Closed
sgwoodjr opened this issue Oct 22, 2015 · 2 comments
Closed

From Boost.Python to PYBIND11 #5

sgwoodjr opened this issue Oct 22, 2015 · 2 comments

Comments

@sgwoodjr
Copy link

Hi,
First off, great job on the library. It looks very promising.

Now to my question. I have a set of functions where each one returns a custom container class called vec. Below is an example wrapper using boost.python with num_util by Phil Austin. Basically num_util takes an iterator and returns a numpy array.

How would I achieve the same results using pybind11?

namespace nbpl = num_util;
namespace bp = boost::python;

bpn::array mybartlett(int L)
{
    // This is a call to my custom function that returns a custom vector
    vec w = bartlett(L);

    // This copies the data in w into the numpy array out
    bpn::array out = nbpl::makeNum(w.begin(), w.size());

    return out;
}
@wjakob
Copy link
Member

wjakob commented Oct 22, 2015

The simplest way would be to just use the builtin STL support (see the docs + examples) by converting your custom type to a std::vector. Otherwise, you could replicate the functionality of nbpl::makeNum by writing code which converts your type to a pybind::list (analogous to the boost::python::list wrapper). This should not be hard with the documentation + example materials.

@wjakob wjakob closed this as completed Oct 22, 2015
@wjakob
Copy link
Member

wjakob commented Oct 22, 2015

(feel free to reopen if this does not address your question)

nbigaouette pushed a commit to nbigaouette/pybind11 that referenced this issue Jan 12, 2016
This should insure that both the PythonLibs and PythonInterp points to
the same python version.

Without this, the Python library and interpreter might not match version.
For example, if both Python 2.7 and 3.4 is installed, PythonLibs will
find /usr/lib/x86_64-linux-gnu/libpython3.4m.so while
PythonInterp will find /usr/bin/python2.7 (at least on Ubuntu 14.04).

When PythonLibs and PythonInterp don't point to the same Python version,
the examples will all fail:

$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Setting build type to 'MinSizeRel' as none was specified.
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython3.4m.so (found suitable version "3.4.3", minimum required is "2.7")
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.6", minimum required is "2.7")
-- Performing Test HAS_LTO_FLAG
-- Performing Test HAS_LTO_FLAG - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /home/nbigaouette/pybind11/build
$ make test
Running tests...
Test project /home/nbigaouette/pybind11/build
      Start  1: example1
 1/12 Test  pybind#1: example1 .........................***Failed    0.02 sec
      Start  2: example2
 2/12 Test  pybind#2: example2 .........................***Failed    0.03 sec
      Start  3: example3
 3/12 Test  pybind#3: example3 .........................***Failed    0.02 sec
      Start  4: example4
 4/12 Test  pybind#4: example4 .........................***Failed    0.02 sec
      Start  5: example5
 5/12 Test  pybind#5: example5 .........................***Failed    0.02 sec
      Start  6: example6
 6/12 Test  pybind#6: example6 .........................***Failed    0.02 sec
      Start  7: example7
 7/12 Test  pybind#7: example7 .........................***Failed    0.02 sec
      Start  8: example8
 8/12 Test  pybind#8: example8 .........................***Failed    0.02 sec
      Start  9: example9
 9/12 Test  pybind#9: example9 .........................***Failed    0.02 sec
      Start 10: example10
10/12 Test pybind#10: example10 ........................***Failed    0.02 sec
      Start 11: example11
11/12 Test pybind#11: example11 ........................***Failed    0.03 sec
      Start 12: example12
12/12 Test pybind#12: example12 ........................***Failed    0.02 sec

0% tests passed, 12 tests failed out of 12

Total Test time (real) =   0.25 sec

The following tests FAILED:
          1 - example1 (Failed)
          2 - example2 (Failed)
          3 - example3 (Failed)
          4 - example4 (Failed)
          5 - example5 (Failed)
          6 - example6 (Failed)
          7 - example7 (Failed)
          8 - example8 (Failed)
          9 - example9 (Failed)
         10 - example10 (Failed)
         11 - example11 (Failed)
         12 - example12 (Failed)
Errors while running CTest
make: *** [test] Error 8


By adding the EXACT version to the find_package() calls, the version
discrepency is at least caught at the cmake call:

$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Setting build type to 'MinSizeRel' as none was specified.
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find PythonLibs: Found unsuitable version "3.4.3", but required
  is exact version "2.7" (found /usr/lib/x86_64-linux-gnu/libpython3.4m.so)
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:313 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-2.8/Modules/FindPythonLibs.cmake:208 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:27 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/nbigaouette/pybind11/build/CMakeFiles/CMakeOutput.log".
nbigaouette pushed a commit to nbigaouette/pybind11 that referenced this issue Jan 12, 2016
…ts to

the same python version.

Without this, the Python library and interpreter might not match version.
For example, if both Python 2.7 and 3.4 is installed, `PythonLibs` will
find /usr/lib/x86_64-linux-gnu/libpython3.4m.so while
`PythonInterp` will find /usr/bin/python2.7 (at least on Ubuntu 14.04).

When `PythonLibs` and `PythonInterp` don't point to the same Python version,
the examples will all fail:

```bash
$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Setting build type to 'MinSizeRel' as none was specified.
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython3.4m.so (found suitable version "3.4.3", minimum required is "2.7")
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.6", minimum required is "2.7")
-- Performing Test HAS_LTO_FLAG
-- Performing Test HAS_LTO_FLAG - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /home/nbigaouette/pybind11/build
$ make test
Running tests...
Test project /home/nbigaouette/pybind11/build
      Start  1: example1
 1/12 Test  pybind#1: example1 .........................***Failed    0.02 sec
      Start  2: example2
 2/12 Test  pybind#2: example2 .........................***Failed    0.03 sec
      Start  3: example3
 3/12 Test  pybind#3: example3 .........................***Failed    0.02 sec
      Start  4: example4
 4/12 Test  pybind#4: example4 .........................***Failed    0.02 sec
      Start  5: example5
 5/12 Test  pybind#5: example5 .........................***Failed    0.02 sec
      Start  6: example6
 6/12 Test  pybind#6: example6 .........................***Failed    0.02 sec
      Start  7: example7
 7/12 Test  pybind#7: example7 .........................***Failed    0.02 sec
      Start  8: example8
 8/12 Test  pybind#8: example8 .........................***Failed    0.02 sec
      Start  9: example9
 9/12 Test  pybind#9: example9 .........................***Failed    0.02 sec
      Start 10: example10
10/12 Test pybind#10: example10 ........................***Failed    0.02 sec
      Start 11: example11
11/12 Test pybind#11: example11 ........................***Failed    0.03 sec
      Start 12: example12
12/12 Test pybind#12: example12 ........................***Failed    0.02 sec

0% tests passed, 12 tests failed out of 12

Total Test time (real) =   0.25 sec

The following tests FAILED:
          1 - example1 (Failed)
          2 - example2 (Failed)
          3 - example3 (Failed)
          4 - example4 (Failed)
          5 - example5 (Failed)
          6 - example6 (Failed)
          7 - example7 (Failed)
          8 - example8 (Failed)
          9 - example9 (Failed)
         10 - example10 (Failed)
         11 - example11 (Failed)
         12 - example12 (Failed)
Errors while running CTest
make: *** [test] Error 8
```

By adding the `EXACT` version to the `find_package()` calls, the version
discrepancy is at least caught at the cmake call:

```bash
$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Setting build type to 'MinSizeRel' as none was specified.
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find PythonLibs: Found unsuitable version "3.4.3", but required
  is exact version "2.7" (found /usr/lib/x86_64-linux-gnu/libpython3.4m.so)
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:313 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-2.8/Modules/FindPythonLibs.cmake:208 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:27 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/nbigaouette/pybind11/build/CMakeFiles/CMakeOutput.log".
```
nbigaouette pushed a commit to nbigaouette/pybind11 that referenced this issue Jan 12, 2016
This should insure that both the `PythonLibs` and `PythonInterp` points to
the same python version.

Without this, the Python library and interpreter might not match version.
For example, if both Python 2.7 and 3.4 is installed, `PythonLibs` will
find /usr/lib/x86_64-linux-gnu/libpython3.4m.so while
`PythonInterp` will find /usr/bin/python2.7 (at least on Ubuntu 14.04).

When `PythonLibs` and `PythonInterp` don't point to the same Python version,
the examples will all fail:

```bash
$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Setting build type to 'MinSizeRel' as none was specified.
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython3.4m.so (found suitable version "3.4.3", minimum required is "2.7")
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.6", minimum required is "2.7")
-- Performing Test HAS_LTO_FLAG
-- Performing Test HAS_LTO_FLAG - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /home/nbigaouette/pybind11/build
$ make test
Running tests...
Test project /home/nbigaouette/pybind11/build
      Start  1: example1
 1/12 Test  pybind#1: example1 .........................***Failed    0.02 sec
      Start  2: example2
 2/12 Test  pybind#2: example2 .........................***Failed    0.03 sec
      Start  3: example3
 3/12 Test  pybind#3: example3 .........................***Failed    0.02 sec
      Start  4: example4
 4/12 Test  pybind#4: example4 .........................***Failed    0.02 sec
      Start  5: example5
 5/12 Test  pybind#5: example5 .........................***Failed    0.02 sec
      Start  6: example6
 6/12 Test  pybind#6: example6 .........................***Failed    0.02 sec
      Start  7: example7
 7/12 Test  pybind#7: example7 .........................***Failed    0.02 sec
      Start  8: example8
 8/12 Test  pybind#8: example8 .........................***Failed    0.02 sec
      Start  9: example9
 9/12 Test  pybind#9: example9 .........................***Failed    0.02 sec
      Start 10: example10
10/12 Test pybind#10: example10 ........................***Failed    0.02 sec
      Start 11: example11
11/12 Test pybind#11: example11 ........................***Failed    0.03 sec
      Start 12: example12
12/12 Test pybind#12: example12 ........................***Failed    0.02 sec

0% tests passed, 12 tests failed out of 12

Total Test time (real) =   0.25 sec

The following tests FAILED:
          1 - example1 (Failed)
          2 - example2 (Failed)
          3 - example3 (Failed)
          4 - example4 (Failed)
          5 - example5 (Failed)
          6 - example6 (Failed)
          7 - example7 (Failed)
          8 - example8 (Failed)
          9 - example9 (Failed)
         10 - example10 (Failed)
         11 - example11 (Failed)
         12 - example12 (Failed)
Errors while running CTest
make: *** [test] Error 8
```

By adding the `EXACT` version to the `find_package()` calls, the version
discrepancy is at least caught at the cmake call:

```bash
$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Setting build type to 'MinSizeRel' as none was specified.
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find PythonLibs: Found unsuitable version "3.4.3", but required
  is exact version "2.7" (found /usr/lib/x86_64-linux-gnu/libpython3.4m.so)
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:313 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-2.8/Modules/FindPythonLibs.cmake:208 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:27 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/nbigaouette/pybind11/build/CMakeFiles/CMakeOutput.log".
```
EricCousineau-TRI referenced this issue in EricCousineau-TRI/pybind11 Apr 10, 2018
EricCousineau-TRI referenced this issue in EricCousineau-TRI/pybind11 Apr 11, 2018
sschnug pushed a commit to sschnug/pybind11 that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants