Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start clang tidy testing #27

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Start clang tidy testing #27

merged 4 commits into from
Feb 13, 2025

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Feb 6, 2025

Starting to implement some clang tidy fixes in preparation of making it part of the CI

@kratman kratman self-assigned this Feb 6, 2025
@kratman kratman marked this pull request as ready for review February 13, 2025 15:36
@kratman kratman requested a review from a team as a code owner February 13, 2025 15:36
@kratman
Copy link
Contributor Author

kratman commented Feb 13, 2025

Windows build unrelated, tested locally using the PyBaMM tests

Copy link
Member

@MarcBerliner MarcBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kratman kratman merged commit 8d80f1c into main Feb 13, 2025
18 of 19 checks passed
@kratman kratman deleted the feat/clangTidy branch February 13, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants