Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Link #174

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Conversation

Bashamega
Copy link
Contributor

closes #171

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit c99a4e2
🔍 Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/66b4b116a954ba000816e1cc
😎 Deploy Preview https://deploy-preview-174--pybamm-developer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arjxn-py

This comment was marked as outdated.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bashamega, I hope you must be looking into bringing star & fork badge on index page too.

config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
@Bashamega
Copy link
Contributor Author

Sorry, they i thought they said the org

@Bashamega Bashamega requested a review from arjxn-py July 31, 2024 09:12
@arjxn-py
Copy link
Member

Sorry, they i thought they said the org

No worries, thanks for fixing :)
Lastly I just want to confirm if you're also looking into getting badges on index page too so that we can wait for you & if not just let me know and I'll be happy to approve then.

@Bashamega
Copy link
Contributor Author

Sorry, they i thought they said the org

No worries, thanks for fixing :) Lastly I just want to confirm if you're also looking into getting badges on index page too so that we can wait for you & if not just let me know and I'll be happy to approve then.

Sure, I will try to complete it

@Bashamega
Copy link
Contributor Author

Hello @arjxn-py . I re-read @agriyakhetarpal and he said that it will be added in #172 . Do you still want me to do it?

@arjxn-py
Copy link
Member

I guess he meant that we can add those badges after the changes in #172, I think we would have to wait for #172 to get in first and then rebase this branch.

@Bashamega
Copy link
Contributor Author

I guess he meant that we can add those badges after the changes in #172, I think we would have to wait for #172 to get in first and then rebase this branch.

I can easily add it. If you want

@Bashamega
Copy link
Contributor Author

I have added the badge

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bashamega, nice work.
I'd like the badges better in a single row.
And alignment is a bit off when aligned left, center align should be better.

@Bashamega
Copy link
Contributor Author

Thanks @Bashamega, nice work. I'd like the badges better in a single row. And alignment is a bit off when aligned left, center align should be better.

On my view it is on one row. I don't know how to center it. Can you commit it?

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bashamega

@agriyakhetarpal agriyakhetarpal merged commit c15de20 into pybamm-team:main Aug 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github link
3 participants