-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Git Initialisation Hooks #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @santacodes! I haven't tested this locally but could you confirm if this is working locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @santacodes! While I shall approve this PR now so that it gets your other PR going, I would suggest that we provide an option in the template to not require hatch-vcs
by default. Making this it an opt-in piece of functionality would be great, this way, this script would not be needed for installing the package. Moreover, I feel that new users of PyBaMM and newcomers to Python packaging would like to hardcode the package version in a string instead of trying to wrap their heads around version control systems.
Yes it does, I tested it locally before pushing it. |
I'm also testing it quick locally |
I completely agree, I will add a new prompt for that to opt-in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, I'd now need to re-configure my git name & mail 😆
git
initialisation hooks in the template to automatically initialise agit repository
when agenerated project
is created bycookiecutter
.main
branch parameter for git repository initialisation.Subtask - #26