Migrated entry points #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santacodes
requested review from
brosaplanella,
arjxn-py,
Saransh-cpp and
agriyakhetarpal
16 tasks
agriyakhetarpal
approved these changes
Jul 19, 2024
{{cookiecutter.project_name}}/src/{{cookiecutter.__project_slug}}/models/input/SPM.py
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/src/{{cookiecutter.__project_slug}}/parameters/input/Chen2020.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Saransh-cpp
reviewed
Jul 19, 2024
Saransh-cpp
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks, @santacodes! Looks good to me now! A couple of comments below -
{{cookiecutter.project_name}}/src/{{cookiecutter.__project_slug}}/__init__.py
Outdated
Show resolved
Hide resolved
arjxn-py
approved these changes
Jul 22, 2024
agriyakhetarpal
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Looks all good to me, thanks, @santacodes! Just one suggestion on the dependencies for the generated project below
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated entry points from
projectto thetemplate. The generated project only works when the git repository is initialised, so if you are testing it locally dogit initfirst before installing it usingpip.Subtask of #26