Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doctest to CI #25

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Added doctest to CI #25

merged 4 commits into from
Jul 18, 2024

Conversation

santacodes
Copy link
Collaborator

Fixes #20

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @santacodes! Looks good to me! Could you also add the same to the template?

@santacodes
Copy link
Collaborator Author

Thanks, @santacodes! Looks good to me! Could you also add the same to the template?

Would it be okay to wait for this PR and the model entry points PR to merge? Then we could have a separate PR to migrate from the project to the template with all the workflows, tests, and entry points. In that case, we would just have to copy the contents from the project to the template so we wouldn't have to keep track and hand-pick the things missing in the template from the project. I would also like to hear others' opinions on this too.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense too. I'd be happy with either of those.

.github/workflows/test_on_push.yml Outdated Show resolved Hide resolved
.github/workflows/test_on_push.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
.github/workflows/test_on_push.yml Outdated Show resolved Hide resolved
.github/workflows/test_on_push.yml Outdated Show resolved Hide resolved
santacodes and others added 2 commits July 18, 2024 11:11
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
@agriyakhetarpal agriyakhetarpal merged commit db61af5 into pybamm-team:main Jul 18, 2024
19 checks passed
@santacodes santacodes deleted the cidoc branch July 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement nox -s docs in the CI
3 participants