Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code of conduct #10

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

santacodes
Copy link
Collaborator

brosaplanella
brosaplanella previously approved these changes Jun 12, 2024
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just see small suggestion about changing the email.

CODE-OF-CONDUCT.md Outdated Show resolved Hide resolved
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
@brosaplanella brosaplanella merged commit 179211a into pybamm-team:main Jun 12, 2024
@@ -0,0 +1,135 @@
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](code_of_conduct.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This badge should also be updated with the full URL, i.e. https://www.contributor-covenant.org/version/2/1/code_of_conduct.html, feel free to get this in along #9

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh didn't see this review but I have put up another PR for that. #11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see that either and merged it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, we weren't able to catch that as we don't have link checker configured on this one yet, may be we can look forward to configure it

@santacodes santacodes deleted the codeofcon branch June 14, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants