Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 835 initial conditions #839

Merged
merged 9 commits into from
Feb 19, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Move initial condition evaluation to solver (instead of discretisation) so that initial conditions can have inputs

Fixes #835

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Contributor

@TomTranter TomTranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looks good

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #839 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   98.24%   98.24%   +<.01%     
==========================================
  Files         180      180              
  Lines       10250    10254       +4     
==========================================
+ Hits        10070    10074       +4     
  Misses        180      180
Impacted Files Coverage Δ
pybamm/discretisations/discretisation.py 99.75% <100%> (ø) ⬆️
pybamm/solvers/casadi_solver.py 100% <100%> (ø) ⬆️
pybamm/simulation.py 94.33% <100%> (+0.06%) ⬆️
pybamm/solvers/base_solver.py 99.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b0ae7...0a5ce0b. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 53fa5f5 into master Feb 19, 2020
@valentinsulzer valentinsulzer deleted the issue-835-initial-conditions branch February 19, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electrode height input doesn't work with DFN
2 participants