Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#591 fix entropic change bug #702

Merged
merged 3 commits into from
Nov 5, 2019
Merged

#591 fix entropic change bug #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95fddc1
#591 fix entropic change bug
rtimms Nov 4, 2019
29367f4
#591 update changelog
rtimms Nov 4, 2019
f355432
#591 update changelog
rtimms Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

## Bug fixes

- Pass the correct dimensional temperature to open circuit potential ([#702](https://github.com/pybamm-team/PyBaMM/pull/702))
- Adds missing temperature dependence in electrolyte and interface submodels ([#698](https://github.com/pybamm-team/PyBaMM/pull/698))
- Fix differentiation of functions that have more than one argument ([#687](https://github.com/pybamm-team/PyBaMM/pull/687))
- Add warning if `ProcessedVariable` is called outside its interpolation range ([#681](https://github.com/pybamm-team/PyBaMM/pull/681))
Expand Down
1 change: 0 additions & 1 deletion input/parameters/lithium-ion/anodes/graphite_mcmb2528_Marquis2019/parameters.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Name [units],Value,Reference,Notes
# Electrode properties,,,
Negative electrode conductivity [S.m-1],100,Scott Moura FastDFN,graphite
Maximum concentration in negative electrode [mol.m-3],24983.2619938437,Scott Moura FastDFN,
Negative electrode diffusion coefficient [m2.s-1],3.9E-14,Scott Moura FastDFN,
Negative electrode diffusivity [m2.s-1],[function]graphite_mcmb2528_diffusivity_Dualfoil1998,,
Negative electrode OCP [V],[function]graphite_mcmb2528_ocp_Dualfoil1998,
,,,
Expand Down
1 change: 0 additions & 1 deletion input/parameters/lithium-ion/cathodes/lico2_Marquis2019/parameters.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Name [units],Value,Reference,Notes
# Electrode properties,,,
Positive electrode conductivity [S.m-1],10,Scott Moura FastDFN,lithium cobalt oxide
Maximum concentration in positive electrode [mol.m-3],51217.9257309275,Scott Moura FastDFN,
Positive electrode diffusion coefficient [m2.s-1],1E-13,Scott Moura FastDFN,
Positive electrode diffusivity [m2.s-1],[function]lico2_diffusivity_Dualfoil1998,,
Positive electrode OCP [V],[function]lico2_ocp_Dualfoil1998,
,,,
Expand Down
3 changes: 1 addition & 2 deletions input/parameters/lithium-ion/electrolytes/lipf6_Marquis2019/parameters.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ Name [units],Value,Reference,Notes
# Electrolyte properties,,,
Typical electrolyte concentration [mol.m-3],1000,Scott Moura FastDFN,
Cation transference number,0.4,Scott Moura FastDFN,
Typical lithium ion diffusivity [m2.s-1],5.34E-10,Scott Moura FastDFN,
Electrolyte diffusivity [m2.s-1],[function]electrolyte_diffusivity_Capiglia1999,,
Electrolyte conductivity [S.m-1],[function]electrolyte_conductivity_Capiglia1999,,
Electrolyte conductivity [S.m-1],[function]electrolyte_conductivity_Capiglia1999,,
,,,
# Activation energies,,,
Reference temperature [K],298.15,25C,
Expand Down
6 changes: 4 additions & 2 deletions pybamm/parameters/standard_parameters_lithium_ion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,13 +406,15 @@ def m_p(T):
def U_n(c_s_n, T):
"Dimensionless open-circuit potential in the negative electrode"
sto = c_s_n
return (U_n_dimensional(sto, T) - U_n_ref) / potential_scale
T_dim = Delta_T * T + T_ref
return (U_n_dimensional(sto, T_dim) - U_n_ref) / potential_scale


def U_p(c_s_p, T):
"Dimensionless open-circuit potential in the positive electrode"
sto = c_s_p
return (U_p_dimensional(sto, T) - U_p_ref) / potential_scale
T_dim = Delta_T * T + T_ref
return (U_p_dimensional(sto, T_dim) - U_p_ref) / potential_scale


def dUdT_n(c_s_n):
Expand Down