Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dt_min option for IDAKLUSolver #4736

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add dt_min option for IDAKLUSolver #4736

merged 2 commits into from
Jan 6, 2025

Conversation

MarcBerliner
Copy link
Member

Description

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@MarcBerliner MarcBerliner marked this pull request as ready for review January 6, 2025 15:51
@kratman
Copy link
Contributor

kratman commented Jan 6, 2025

Tagging my PR so I make sure to include these changes #4487

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (a7253b8) to head (c44ef14).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4736      +/-   ##
===========================================
+ Coverage    99.22%   99.24%   +0.01%     
===========================================
  Files          303      303              
  Lines        23070    23242     +172     
===========================================
+ Hits         22891    23066     +175     
+ Misses         179      176       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcBerliner MarcBerliner merged commit 198fdb7 into develop Jan 6, 2025
25 checks passed
@MarcBerliner MarcBerliner deleted the idaklu-add-dt-min branch January 6, 2025 17:32
@kratman kratman mentioned this pull request Jan 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants