Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reaction heating #4557

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Oct 31, 2024

Description

Implements reaction heating in half cell models for the negative electrode

Fixes #4324

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@aabills
Copy link
Contributor Author

aabills commented Oct 31, 2024

reaction heating implemented but I think heat source is still inaccurate for half-cell models.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (19a7738) to head (7678703).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4557      +/-   ##
===========================================
- Coverage    99.42%   99.29%   -0.14%     
===========================================
  Files          300      300              
  Lines        22774    22776       +2     
===========================================
- Hits         22643    22615      -28     
- Misses         131      161      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabills
Copy link
Contributor Author

aabills commented Nov 4, 2024

I have found the second bug now. I think we should go ahead and merge this and discuss the second bug in a second issue, which I will open momentarily. The reason for a second PR is that the second bug could have ramifications outside of the files addressed in this pull request.

@aabills aabills marked this pull request as ready for review November 4, 2024 17:28
@aabills
Copy link
Contributor Author

aabills commented Nov 4, 2024

Not sure if we want to address this here or elsewhere (due to the second bug, this will fail for now), but I think we should start testing conservation of energy to catch stuff like this.

@kratman kratman merged commit f4e4955 into pybamm-team:develop Nov 4, 2024
24 checks passed
pkalbhor pushed a commit to pkalbhor/PyBaMM that referenced this pull request Nov 15, 2024
* add reaction heating

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Half cell negative reaction heating set to 0
3 participants