Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sodium-ion DFN #4451

Merged
merged 25 commits into from
Oct 7, 2024
Merged

Implement sodium-ion DFN #4451

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
cd8ffef
add sodium-ion model, parameters and examples
brosaplanella Sep 18, 2024
e663938
update citation keys to be consistent
brosaplanella Sep 18, 2024
952a3e2
Merge branch 'develop' into na-ion
brosaplanella Sep 18, 2024
e0cfd66
rename electrolyte conductivity from kappa to sigma
brosaplanella Sep 19, 2024
a318ec1
add tests for sodium ion
brosaplanella Sep 19, 2024
d86e057
Merge branch 'na-ion' of github.com:pybamm-team/PyBaMM into na-ion
brosaplanella Sep 19, 2024
b6b5630
Merge branch 'develop' into na-ion
brosaplanella Sep 19, 2024
b56bdf2
fix doctests
brosaplanella Sep 19, 2024
2eb96e1
Merge branch 'na-ion' of github.com:pybamm-team/PyBaMM into na-ion
brosaplanella Sep 19, 2024
48557ee
fix doctest
brosaplanella Sep 19, 2024
47f74d5
Merge branch 'develop' into na-ion
brosaplanella Sep 19, 2024
f3d58e7
remove accidentally added example
brosaplanella Sep 19, 2024
d733bc5
Merge branch 'na-ion' of github.com:pybamm-team/PyBaMM into na-ion
brosaplanella Sep 19, 2024
26631e0
Merge branch 'develop' into na-ion
kratman Sep 19, 2024
bff18ad
commented better the volume fraction
brosaplanella Sep 22, 2024
e2ff23c
write volume fractions as a single number, not a substraction
brosaplanella Sep 24, 2024
c9eea70
Merge branch 'na-ion' of github.com:pybamm-team/PyBaMM into na-ion
brosaplanella Sep 24, 2024
8c8e862
Merge branch 'develop' into na-ion
brosaplanella Sep 24, 2024
7695350
Merge remote-tracking branch 'origin/develop' into na-ion
brosaplanella Oct 2, 2024
f3b2bb6
improve basic tests
brosaplanella Oct 3, 2024
1d8d580
Merge branch 'develop' into na-ion
brosaplanella Oct 3, 2024
478337e
update CHANGELOG
brosaplanella Oct 3, 2024
83bdad6
update CHANGELOG
brosaplanella Oct 3, 2024
703dd1d
Merge branch 'develop' into na-ion
kratman Oct 7, 2024
00c4412
Merge branch 'develop' into na-ion
kratman Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/examples/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ The notebooks are organised into subfolders, and can be viewed in the galleries
notebooks/models/SEI-on-cracks.ipynb
notebooks/models/simulate-3E-cell.ipynb
notebooks/models/simulating-ORegan-2022-parameter-set.ipynb
notebooks/models/sodium-ion.ipynb
notebooks/models/SPM.ipynb
notebooks/models/SPMe.ipynb
notebooks/models/submodel_cracking_DFN_or_SPM.ipynb
Expand Down
185 changes: 185 additions & 0 deletions docs/source/examples/notebooks/models/sodium-ion.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ Ramadass2004 = "pybamm.input.parameters.lithium_ion.Ramadass2004:get_parameter_v
Xu2019 = "pybamm.input.parameters.lithium_ion.Xu2019:get_parameter_values"
ECM_Example = "pybamm.input.parameters.ecm.example_set:get_parameter_values"
MSMR_Example = "pybamm.input.parameters.lithium_ion.MSMR_example_set:get_parameter_values"
Chayambuka2022 = "pybamm.input.parameters.sodium_ion.Chayambuka2022:get_parameter_values"

[tool.setuptools]
include-package-data = true
Expand Down
Loading
Loading