Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-build-core CI Builds #4242

Closed
wants to merge 169 commits into from

Conversation

cringeyburger
Copy link
Contributor

@cringeyburger cringeyburger commented Jul 4, 2024

Description

Added Linux and MacOS builds using scikit-build-core; there is some redundant code that needs to be cleared

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@cringeyburger
Copy link
Contributor Author

I ran the benchmarks, here is the job. It failed though.

@agriyakhetarpal
Copy link
Member

We just merged #4311 to move to an src layout, which means that this PR now has some conflicts (apologies for the disruption). I think they should be fairly resolvable and the builds should mostly work, but if you face any issues with this, let us know! We have a guide for you that should make it easier.

@agriyakhetarpal
Copy link
Member

Superseded by #4352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants