Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flat layout to src layout. #4205

Closed
wants to merge 5 commits into from

Conversation

prady0t
Copy link
Contributor

@prady0t prady0t commented Jun 23, 2024

Description

Superseded by #4311


Moving to a src layout is a better option overall. You can read more about it here: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/#:~:text=Auto%20color%20theme-,src%20layout%20vs%20flat%20layout,-%23

It was decided internally to move to a src layout.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Copy link
Contributor Author

prady0t commented Jun 23, 2024

@agriyakhetarpal I think I've added everything, please let me know if I have to add anything else here once the tests are completed.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (205ca81) to head (666c626).
Report is 262 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4205   +/-   ##
========================================
  Coverage    99.55%   99.55%           
========================================
  Files          288      288           
  Lines        21857    21857           
========================================
  Hits         21760    21760           
  Misses          97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MANIFEST.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@agriyakhetarpal
Copy link
Member

Just noticed, we'll have to fix the doctests and the example notebooks

prady0t and others added 4 commits June 23, 2024 23:37
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@agriyakhetarpal
Copy link
Member

Let's rebase this now, @prady0t

@prady0t prady0t mentioned this pull request Aug 2, 2024
8 tasks
@prady0t
Copy link
Contributor Author

prady0t commented Aug 2, 2024

@agriyakhetarpal Opened a new PR, I wasn't able to fix the conflicts locally.

@agriyakhetarpal
Copy link
Member

Superseded by #4311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants