-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving from flat layout to src layout. #4205
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@agriyakhetarpal I think I've added everything, please let me know if I have to add anything else here once the tests are completed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4205 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 288 288
Lines 21857 21857
========================================
Hits 21760 21760
Misses 97 97 ☔ View full report in Codecov by Sentry. |
Just noticed, we'll have to fix the doctests and the example notebooks |
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
…rc-layout Merging.
Let's rebase this now, @prady0t |
@agriyakhetarpal Opened a new PR, I wasn't able to fix the conflicts locally. |
Superseded by #4311 |
Description
Superseded by #4311
Moving to a src layout is a better option overall. You can read more about it here: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/#:~:text=Auto%20color%20theme-,src%20layout%20vs%20flat%20layout,-%23
It was decided internally to move to a
src
layout.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: