Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CasADi 3.6.5 #4063

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

Fixes #4044

Wheels are building: pybamm-team/casadi-vcpkg-registry#1
Workflow run logs: https://github.com/agriyakhetarpal/PyBaMM/actions/runs/8950718520/job/24586326296

https://github.com/pybamm-team/casadi-vcpkg-registry has been updated and the baseline has been updated accordingly.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@agriyakhetarpal
Copy link
Member Author

#3783 requires repairing the wheel – it would be better to keep that separately tracked as it is now. This PR is ready for review and merging, since CasADi is getting compiled successfully.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (febf1ac) to head (442532a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4063   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          259      259           
  Lines        21353    21353           
========================================
  Hits         21266    21266           
  Misses          87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjxn-py
Copy link
Member

arjxn-py commented May 6, 2024

Thanks @agriyakhetarpal.

@arjxn-py arjxn-py merged commit 2496688 into pybamm-team:develop May 6, 2024
42 checks passed
@agriyakhetarpal agriyakhetarpal deleted the build-casadi-3.6.5 branch May 6, 2024 11:55
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* Update vcpkg baseline

* Bump CasADi to minimum 3.6.5, both build and run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to CasADi v3.6.5 for Windows wheels
2 participants