Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degradation example update #3691

Merged
merged 15 commits into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

## Bug fixes

- Reverted a change to the coupled degradation example notebook that caused it to be unstable for large numbers of cycles ([#3691](https://github.com/pybamm-team/PyBaMM/pull/3691))
- Fixed a bug where simulations using the CasADi-based solvers would fail randomly with the half-cell model ([#3494](https://github.com/pybamm-team/PyBaMM/pull/3494))
- Fixed bug that made identical Experiment steps with different end times crash ([#3516](https://github.com/pybamm-team/PyBaMM/pull/3516))
- Fixed bug in calculation of theoretical energy that made it very slow ([#3506](https://github.com/pybamm-team/PyBaMM/pull/3506))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,22 +105,21 @@
"cycle_number = 10\n",
"exp = pybamm.Experiment(\n",
" [\n",
" \"Hold at 4.2 V until C/100\",\n",
" \"Rest for 4 hours\",\n",
" \"Discharge at 0.1C until 2.5 V\", # initial capacity check\n",
" \"Charge at 0.3C until 4.2 V\",\n",
" \"Hold at 4.2 V until C/100\",\n",
" \"Hold at 4.2 V until C/100 (5 minute period)\",\n",
" \"Rest for 4 hours (5 minute period)\",\n",
" \"Discharge at 0.1C until 2.5 V (5 minute period)\", # initial capacity check\n",
" \"Charge at 0.3C until 4.2 V (5 minute period)\",\n",
" \"Hold at 4.2 V until C/100 (5 minute period)\",\n",
" ]\n",
" + [\n",
" (\n",
" \"Discharge at 1C until 2.5 V\", # ageing cycles\n",
" \"Charge at 0.3C until 4.2 V\",\n",
" \"Hold at 4.2 V until C/100\",\n",
" \"Charge at 0.3C until 4.2 V (5 minute period)\",\n",
" \"Hold at 4.2 V until C/100 (5 minute period)\",\n",
" )\n",
" ]\n",
" * cycle_number\n",
" + [\"Discharge at 0.1C until 2.5 V\"], # final capacity check\n",
" period=\"5 minutes\",\n",
" + [\"Discharge at 0.1C until 2.5 V (5 minute period)\"], # final capacity check\n",
")\n",
"sim = pybamm.Simulation(model, parameter_values=param, experiment=exp, var_pts=var_pts)\n",
"sol = sim.solve()"
Expand Down
Loading