-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i3639 Fix Python 3.12 tests #3645
i3639 Fix Python 3.12 tests #3645
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3645 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 258 258
Lines 20778 20778
========================================
Hits 20693 20693
Misses 85 85 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, @agriyakhetarpal! IIRC pybtex is not maintained anymore and it would be greatly appreciated if you fix this issue upstream.
If pybibtex is dead, should we switch to something else instead? I found this active project for parsing bibtex: https://github.com/sciunto-org/python-bibtexparser |
I was looking at some projects too yesterday and this one looks good to me as well. I will convert your comment to an issue, @kratman – an upstream PR for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agriyakhetarpal, looks good.
+1 for @kratman's suggestion as that project looks actively maintained, though it'll be also appreciated to look into the issue upstream. Maybe we can decide upon the complexity of the issue upstream.
Description
Closes #3639. This is a minimal and temporary fix for now, I will chase this down soon and try to fix the issue for the
pybtex
repository upstream when I get time.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: