Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3639 Fix Python 3.12 tests #3645

Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

Closes #3639. This is a minimal and temporary fix for now, I will chase this down soon and try to fix the issue for the pybtex repository upstream when I get time.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85d930a) 99.59% compared to head (86e0e15) 99.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3645   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        20778    20778           
========================================
  Hits         20693    20693           
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, @agriyakhetarpal! IIRC pybtex is not maintained anymore and it would be greatly appreciated if you fix this issue upstream.

@kratman
Copy link
Contributor

kratman commented Dec 20, 2023

If pybibtex is dead, should we switch to something else instead?

I found this active project for parsing bibtex: https://github.com/sciunto-org/python-bibtexparser

@agriyakhetarpal
Copy link
Member Author

I was looking at some projects too yesterday and this one looks good to me as well. I will convert your comment to an issue, @kratman – an upstream PR for pybtex is on my radar for the start of next year as soon as my exams end, which should suffice our requirements, but switching to a new dependency altogether would be great.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agriyakhetarpal, looks good.
+1 for @kratman's suggestion as that project looks actively maintained, though it'll be also appreciated to look into the issue upstream. Maybe we can decide upon the complexity of the issue upstream.

@valentinsulzer valentinsulzer merged commit 1943aa5 into pybamm-team:develop Dec 20, 2023
41 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix-python-3.12-ci branch December 21, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 CI tests are failing due to pybtex
5 participants