Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where the SEI thickness decreased at some intervals when using the 'electron-migration limited' model. #3622

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Fixed a bug where the SEI thickness decreased at some intervals when using the 'electron-migration limited' model. #3622

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed6f04d
The 'electron-migration limited' model has been corrected by consider…
kawaMANMI Dec 14, 2023
066c340
Update pybamm/models/submodels/interface/sei/sei_growth.py
kawaMANMI Dec 15, 2023
e05da9d
Logical condition (eta_inner < 0) used instead pybamm.EqualHeaviside …
kawaMANMI Jan 18, 2024
3197432
Logical condition (eta_inner < 0) used instead pybamm.EqualHeaviside …
kawaMANMI Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pybamm/models/submodels/interface/sei/sei_growth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ def get_coupled_variables(self, variables):
elif SEI_option == "electron-migration limited":
# Scott Marquis thesis (eq. 5.94)
eta_inner = delta_phi - phase_param.U_inner
j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner

j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner * pybamm.EqualHeaviside(eta_inner, 0)
elif SEI_option == "interstitial-diffusion limited":
# Scott Marquis thesis (eq. 5.96)
j_sei = -(
Expand Down